Problem/Motivation

#3506444: UserThemeHooks::preprocessUsername() doesn't handle cacheability correctly introduces a new access operation for users that should also be ignored. We saw this pop up because it resulted in additional queries being run that didn't happen before. This operation should also be excluded from the checks.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork userprotect-3588357

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

berdir opened merge request !18

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

This is a quickfix. It might make more sense to have a list of operations that this module *does* care about, I'm also confused about those special user_mail and similar operations. These do not exist in core, something like that should be handled through field access, not entity access.

  • megachriz committed 2b2e3c95 on 8.x-1.x authored by berdir 
    fix: #3588357 Ignore new "view linked label" access operation when...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Thanks for the MR. I've scheduled the merge.

I'm also confused about those special user_mail and similar operations

This was the first module that I ported to Drupal 8, back in 2014. It was in the first place a way for me to learn the new Drupal API's, so that may explain the less optimal choices.
If I'm not mistaken, the user fields to be protected weren't regular field API fields yet at the time - or at least not on the form code, so that could also be an explanation for the design choice.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.