Problem/Motivation

For the entity_list tool, when I ran the tool both in the Tool Explorer and as a tool invoked by an agent, I saw that the output included <em> tags that both in the Drupal admin UI message and in the output returned to the agent show the <em> tags escaped. Per the output in all of the other tools, the '@' placeholder should be used in output instead of the '%' placeholder.

Steps to reproduce

Run the entity_list tool or the send email tool and check the output. You should see the escaped <em> tags.

Proposed resolution

Change the placeholders used in the t() call to '@'.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork tool_belt-3587953

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jaydub created an issue. See original summary.

jaydub’s picture

StatusFileSize
new2.91 KB

Here is a quick patch.

jaydub’s picture

Issue summary: View changes
jaydub’s picture

Issue summary: View changes
ajits’s picture

Version: 1.0.0-alpha1 » 1.0.x-dev
Assigned: Unassigned » ajits

Checking this now.

ajits’s picture

Confirmed that without MR on my local

entity_list returned "Returned 3 Content(node) entities out of a total 3"

send_main returned "Sent email to test@test.com"

ajits’s picture

Created a MR from the patch to trigger the pipeline.

  • ajits committed 199b7200 on 1.0.x
    fix: #3587953 Change placeholder type for output messages in two tools
    
ajits’s picture

Assigned: ajits » Unassigned
Status: Needs review » Fixed

Thank you for the report and the patch. Committed and pushed to 1.0.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.