Problem/Motivation

The module doesn't have a .gitlab-ci.yml for CI and furthermore it's unclear if it's fully D11 compatible and if code style is fine.

Would be great to fix that all now.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork jsonapi_views-3587949

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !13

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Add gitlab-ci.yml and fix remaining phpcs, and other code style issues » Add gitlab-ci.yml and fix remaining schema, cspell, phpstan, phpcs, and other code style issues
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Major

Most important is to get phpunit green again. But we should also resolve all the other CI issues here.

kieran.cott made their first commit to this issue’s fork.

kieran.cott’s picture

kieran.cott
Location Manila 🇵🇭
commented

I’ve pushed up a fix addressing the functional test schema failure, PHPCS/PHPStan findings in ViewsResource, and the CSpell errors. I also updated the cache context assertions to handle Drupal’s optimised url.query_args context.

I've also run JsonapiViewsResourceTest locally in DDEV: 6 tests, 168 assertions passed.

I've tested this manually and there don't appear to be any regressions in functionality.

There are still some existing PHPUnit deprecation notices, but pipelines are now green.

kieran.cott’s picture

kieran.cott
Location Manila 🇵🇭
commented
Status: Active » Needs review

  • deciphered committed 1eb010ec on 8.x-1.x 
    chore(#3587949): apply drupal-extension-scaffold v4.17.0 and fix...

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Fixed

Thanks for getting this rolling, kieran.cott.

Building on your fix, I've re-scaffolded the module to drupal_extension_scaffold v4.17.0 and got the pipeline genuinely green.

Pushed to 8.x-1.x: 3e50d79.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.