Problem/Motivation
The phpstan job failed.
Line footable.module
------ ---------------------------------------------------------------------------
51 Call to deprecated function template_preprocess_views_view_table():
in drupal:11.3.0 and is removed from drupal:12.0.0. Initial
template_preprocess functions are registered directly in hook_theme().
99 Variable $field_handler in empty() always exists and is not falsy.
------ ---------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------
Line src/Entity/FooTableBreakpoint.php
------ -----------------------------------------------------------------------------------------------
102 Call to an undefined method Drupal\Core\Config\Entity\ConfigEntityInterface::getBreakpoint().
103 Call to an undefined method Drupal\Core\Config\Entity\ConfigEntityInterface::getBreakpoint().
------ -----------------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------
Line src/FooTable.php
------ ----------------------------------------------------------------------------------
56 Call to an undefined method Drupal\Core\Entity\EntityInterface::getBreakpoint().
------ ----------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------
Line src/FooTableBreakpointListBuilder.php
------ ----------------------------------------------------------------------------------
31 Call to an undefined method Drupal\Core\Entity\EntityInterface::getBreakpoint().
------ ----------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------------------------------
Line src/Form/FooTableBreakpointForm.php
------ ---------------------------------------------------------------------------------------------------------------
46 Call to an undefined method Drupal\Core\Entity\EntityInterface::getBreakpoint().
72 Method Drupal\footable\Form\FooTableBreakpointForm::save() should return int but return statement is missing.
------ ---------------------------------------------------------------------------------------------------------------
[ERROR] Found 8 errors
Steps to reproduce
Go to the https://git.drupalcode.org/issue/footable-3586300/-/jobs/9510357
Check parent issue - (see here https://www.drupal.org/project/footable/issues/3586300).
Proposed resolution
Replace the deprecated function.
Add a return statement.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | phpstan_check.png | 73.69 KB | just-me |
| phpstan.png | 341.39 KB | just-me |
Issue fork footable-3587076
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
just-me commentedComment #3
just-me commentedComment #4
just-me commentedComment #5
just-me commentedComment #7
just-me commentedI've fixed PHPStan errors. Please review it.
Comment #8
just-me commentedSo, I've merged a parent branch(https://www.drupal.org/node/3586300), and the PHPstan job succeeded.
You can check it here https://git.drupalcode.org/issue/footable-3587076/-/jobs/9562026.
Comment #9
quadrexdevLooks good
Comment #11
just-me commentedMerged, thanks to everyone.