Problem/Motivation

The phpstan job failed.

Line footable.module
------ ---------------------------------------------------------------------------
51 Call to deprecated function template_preprocess_views_view_table():
in drupal:11.3.0 and is removed from drupal:12.0.0. Initial
template_preprocess functions are registered directly in hook_theme().
99 Variable $field_handler in empty() always exists and is not falsy.
------ ---------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------
Line src/Entity/FooTableBreakpoint.php
------ -----------------------------------------------------------------------------------------------
102 Call to an undefined method Drupal\Core\Config\Entity\ConfigEntityInterface::getBreakpoint().
103 Call to an undefined method Drupal\Core\Config\Entity\ConfigEntityInterface::getBreakpoint().
------ -----------------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------
Line src/FooTable.php
------ ----------------------------------------------------------------------------------
56 Call to an undefined method Drupal\Core\Entity\EntityInterface::getBreakpoint().
------ ----------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------
Line src/FooTableBreakpointListBuilder.php
------ ----------------------------------------------------------------------------------
31 Call to an undefined method Drupal\Core\Entity\EntityInterface::getBreakpoint().
------ ----------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------------------------------
Line src/Form/FooTableBreakpointForm.php
------ ---------------------------------------------------------------------------------------------------------------
46 Call to an undefined method Drupal\Core\Entity\EntityInterface::getBreakpoint().
72 Method Drupal\footable\Form\FooTableBreakpointForm::save() should return int but return statement is missing.
------ ---------------------------------------------------------------------------------------------------------------

[ERROR] Found 8 errors

Steps to reproduce

Go to the https://git.drupalcode.org/issue/footable-3586300/-/jobs/9510357
Check parent issue - (see here https://www.drupal.org/project/footable/issues/3586300).

Proposed resolution

Replace the deprecated function.
Add a return statement.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#7 phpstan_check.png73.69 KBjust-me
phpstan.png341.39 KBjust-me

Issue fork footable-3587076

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

just-me created an issue. See original summary.

just-me’s picture

Issue summary: View changes
just-me’s picture

Issue summary: View changes
just-me’s picture

Issue summary: View changes
just-me’s picture

Title: CI: resolving phpstan errors » PHPstan job was failed

just-me’s picture

Assigned: just-me » Unassigned
Status: Active » Needs review
StatusFileSize
new73.69 KB

I've fixed PHPStan errors. Please review it.

just-me’s picture

So, I've merged a parent branch(https://www.drupal.org/node/3586300), and the PHPstan job succeeded.
You can check it here https://git.drupalcode.org/issue/footable-3587076/-/jobs/9562026.

quadrexdev’s picture

Looks good

  • just-me committed 3e8064f4 on 8.x-2.x
    feat: #3587076 CI: resolving phpstan errors
    
just-me’s picture

Status: Needs review » Fixed

Merged, thanks to everyone.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.