Problem/Motivation

Matt Glaman wrote a great blogpost on some of the issues that incorrect dependency injection can cause: https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal

Steps to reproduce

Proposed resolution

Ensure we don't implement those mistakes.

This should be fixed before 5.0.0 since it requires subtle API breaks in some classes.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork graphql-3586965

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kingdutch created an issue. See original summary.

kingdutch opened merge request !96

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Active » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

Interesting, code changes look good to me!

  • kingdutch committed 58b399fb on 5.x 
    fix: #3586965 Dependency injection anti-patterns
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.