A few deprecated function errors are appearing in the logs. This patch fixes them.
Deprecated function: Drupal\tome_sync\Normalizer\PathAliasNormalizer::__construct(): Implicitly marking parameter $entity_type_repository as nullable is deprecated, the explicit nullable type must be used instead in include() (line 576 of /home/xxx/d11/vendor/composer/ClassLoader.php)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | tome-php84-nullable.patch | 2.33 KB | mr.white |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !48
Comments
Comment #2
mr.white commentedComment #3
bohus ulrychWorks. Thanks
Tested with PHP 8.4.21 and Drupal 11.3.9 and tome 1.14.0
Comment #6
tribekk commentedOpened MR !48.
This ports the existing PHP 8.4 nullable-parameter patch to an issue fork. The PathAliasNormalizer constructor now receives the required entity repository before the optional entity type repository and entity field manager dependencies, with those optional parameters explicitly nullable. The service arguments are reordered to match.
Checked locally: composer validate --no-check-publish; php -l modules/tome_sync/src/Normalizer/PathAliasNormalizer.php; git diff --check.
Credit to mr.white for the original patch.
Comment #7
tribekk commentedCI note for MR !48 / pipeline #829842:
Focused checks still pass:
- composer validate --no-check-publish
- php -l modules/tome_sync/src/Normalizer/PathAliasNormalizer.php
- git diff --check
I checked the failed jobs. They look unrelated to this patch: phpcs/cspell/eslint/stylelint report existing issues across the project, and phpstan/phpunit report existing PHPUnit 11/static data provider and Tome functional/kernel failures. None of the failures point at PathAliasNormalizer.php or the updated service argument.
Comment #8
larowlanhttps://www.drupal.org/project/tome/releases/8.x-1.15
Fixed thanks
Comment #11
joseph.olstad