Problem/Motivation

Lines 38–115 of src/Traits/NameFormSettingsHelperTrait.php build table structure by concatenating raw HTML strings with $form[$child]['#title']. It's safe today because titles derive from NameComponentMetadataService::getTranslations() (hardcoded labels), but the pattern is fragile — any future contributor passing dynamic data into #title would land it in an unescaped prefix.

Steps to reproduce

Proposed resolution

Recommendation: migrate to #type => 'table'.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork name-3586339

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

bluegeek9’s picture

bluegeek9 commented
Issue summary: View changes

bluegeek9 opened merge request !86

  • bluegeek9 committed b2bb9ea4 on 8.x-1.x 
    feat: #3586339 Hand-rolled <table>/<tr>/<td> via #prefix/#suffix in...
bluegeek9’s picture

bluegeek9 commented
Status: Active » Fixed
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support makes this project sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.