Problem/Motivation

Remaining tasks

  1. The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-stable-9. (For example, the CR for removing HAL)
  2. Tag this issue 'Needs release note.'
  3. Remove the extension ;-).
  4. Update update path tests as needed. See Learn how to write an automated update test.
  5. Remove references from core/phpstan-baseline.neon.
  6. Remove any spelling words specific to the extension from the dictionaries.
  7. Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.
  8. Check for references in @todo.

Release notes snippet

The Stable 9 theme has been removed from core, and can now be installed as a contrib Stable 9 theme,

CommentFileSizeAuthor
#14 3586221-nr-bot_4dhtp5q1.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3586221

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !15848

smustgrave’s picture

smustgrave commented

Just seeing if any tests fail once removed, know still need to finish deprecating.

smustgrave’s picture

smustgrave commented
Issue tags: +Needs release note
smustgrave’s picture

smustgrave commented
Status: Postponed » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I verified that the following tasks have been completed:

  1. The change record contains a link to the recommendations page entry.
  2. This issue is properly tagged.
  3. The theme has been completely removed from core/themes/.
  4. No tests needed to be updated.
  5. The baseline has been updated.
  6. There are no additional references to the theme in core that I could find in a search of the code base.

I wasn't able to try regenerating the cspell dictionary because NPM was being uncooperative.

I'm setting the status to Needs Work because the theme name wasn't added to DRUPAL_CORE_REMOVED_THEME_LIST. That constant isn't in system.install any longer. It was moved to core/modules/system/src/Install/Requirements/SystemRequirements.php.

nitinkumar_7 made their first commit to this issue’s fork.

nitinkumar_7’s picture

nitinkumar_7 commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

The addition of the theme to the constant list looks good.

In other news, I got CSpell working on my local and regenerated the dictionaries. While it is apparent that the dictionary needs to be regenerated in general, one of the to-be-removed terms appeared in stable9, "necolas". It's a little strange because the word appears in a couple of other Core files, but probably those are excluded from CSpell scanning. At any rate, according to my findings the term needs to be removed from core/misc/cspell/dictionary.txt, so I'm setting the status back to Needs Work.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Issue tags: -Needs release note
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

My feedback was addressed. LTGM.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3586221-nr-bot_4dhtp5q1.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

meeni_dhobale made their first commit to this issue’s fork.

meeni_dhobale’s picture

meeni_dhobale commented

Rebased MR !15848 onto current main to fix the Needs Review Queue Bot's "no longer applies" flag — the branch was several months stale. Conflicts were only in stable9's own theme files, which had been touched independently on main since. The six supporting edits outside the theme directory - SystemRequirements::DRUPAL_CORE_REMOVED_THEME_LIST, .phpstan-baseline.php, .prettierignore, .stylelintrc.json, MAINTAINERS.txt, and the cspell dictionary - merged cleanly with no changes needed.

Verified stable9 was still discoverable by the theme system before this update, and is now fully removed and registered in the deprecated-theme list. Ran UpdateScriptTest::testMissingExtension, the test that directly covers DRUPAL_CORE_REMOVED_THEME_LIST, and it passes clean, along with PHPCS and the health check.

The full system module test suite didn't finish inside the local 900s check window, so it's worth a full CI run. This update is a pure rebase though - no logic changes beyond syncing with main. MR now applies cleanly against main.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

  • catch committed d60736ee on main 
    task: #3586221 Remove the Stable 9 theme

By: quietone
By: smustgrave
By...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !15848

quietone’s picture

quietone commented

There was a change record on this issue for the removal, but a change record is not needed for removing deprecated code. It turns out that the issue to deprecate stable9 did not have a change record, which it should have. I updated the change record to link to the deprecation issue, fixing the branch/version and publishing with the correct date.