Problem/Motivation

The OembedProvider, ProviderBucket, and OEmbed (our extended version) classes still use annotation. Beginning in Drupal 10.2, support for PHP attributes was added; Support for annotations will be dropped in Drupal 12. See https://www.drupal.org/node/3395575 and https://www.drupal.org/node/3522776.

Proposed resolution

  • Replace annotations with PHP attributes.
  • Update requirements to ^10.2.

Remaining tasks

  1. Create MR
  2. Verify tests pass

User interface changes

None

API changes

None

Data model changes

None

Issue fork oembed_providers-3584986

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chris burge created an issue. See original summary.

chris burge’s picture

chris burge commented
Issue summary: View changes

chris burge opened merge request !30

chris burge’s picture

chris burge commented

providers key is removed from Drupal\oembed_providers\Plugin\media\Source\OEmbed per https://www.drupal.org/project/drupal/issues/3420997#comment-15526394. (Commit)

chris burge’s picture

chris burge commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

chris burge’s picture

chris burge commented
Status: Fixed » Needs work

Jumped the gun a bit here. ConfigEntityType plugins didn't support PHP attribute declaration until D11.1: https://www.drupal.org/node/3505422. The workaround is to restore the attribution declaration. MediaSource plugins added support for PHP attribute declaration in D10.3: https://www.drupal.org/node/3229001.

Proposed resolution:

  • Bump module requirement to ^10.3 || 11 for MediaSource
  • Either revert PHP attributes for OembedProvider and ProviderBucket or add back annotations above attributes.

chris burge opened merge request !33

  • chris burge committed 9b2de3b0 on 2.x 
    Resolve #3584986 "Add back annotations to restore D10 support"
chris burge’s picture

chris burge commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.