Problem/Motivation

This is a very helpful, but also powerful and widely used module. For that reason it should have test coverage!

Would be great if someone could take the time to add tests, from installation to functionality and especially permission handling and security.

In the future also issues should add tests to keep things clean and working! :)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anybody created an issue. See original summary.

kieran.cott made their first commit to this issue’s fork.

kieran.cott’s picture

Status: Active » Needs review

I've added automated coverage for installation, views integration, field editing functionality, permission handling, and security-sensitive submissions in MR 29.

I've also made a small tweak to fix fallback rendering so the tests don't fail when a fallback render array is overwritten by a field widget build.

kieran.cott’s picture

Pipelines fail, but this seems to be unrelated to any changes made here and is addressed in: https://www.drupal.org/project/views_entity_form_field/issues/3582075

anybody’s picture

Issue tags: -Needs tests, -Novice

Thanks @kieran.cott this looks promising. Let's now wait for #3582075: CI: fix phpcs & phpstan issues to be resolved.

anybody’s picture

Assigned: Unassigned » grevil
Status: Needs review » Reviewed & tested by the community

Thanks, all green! Merging!

@grevil could you finally add our basic tests and then close this fixed?

anybody’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.