Problem/Motivation

Spin-off from #3583040: Cache the container definition in APCu.

We have the following in ChainedFastBackendFactory

    // Do not use the fast chained backend during installation. In those cases,
    // we expect many cache invalidations and writes, the fast chained cache
    // backend performs badly in such a scenario.
    if (!InstallerKernel::installationAttempted()) {
      $this->fastServiceName = $fast_service_name;
    }

This is no longer the case since #3526080: Reduce write contention to the fast and consistent backend in ChainedFastBackend.

I don't think we'll see a performance improvement, because the hit rate would still be extremely low, but the cache stampede issue should be fixed, so we could remove a small amount of code.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3584329

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

ishani patel made their first commit to this issue’s fork.

ishani patel’s picture

Assigned: Unassigned » ishani patel

Hello,
I've raised MR.
Kindly check it.

ishani patel’s picture

Assigned: ishani patel » Unassigned
Status: Active » Needs review
catch’s picture

MR looks good, thanks for picking it up!

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seems to have got the thumbs up from @catch so I'll mark so he can merge for ya.

catch’s picture

Status: Reviewed & tested by the community » Needs review

This is my idea so I'm not planning to commit it without an explicit +1 from someone else or would probably leave entirely for another committer.

dries’s picture

Status: Needs review » Reviewed & tested by the community

This looks correct. The "throttling" in markAsOutdated() makes this unnecessary.

alexpott’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

I tested locally with apcu enabled and saw no slow down in install times

Committed and pushed 4f2ff40d2b4 to main and e37c23755ae to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed e37c2375 on 11.x
    task: #3584329 Re-evaluate skipping the chained fast backend in the...

  • alexpott committed 4f2ff40d on main
    task: #3584329 Re-evaluate skipping the chained fast backend in the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.