Problem/Motivation

There are multiple references to gin_ variables or gin_ form elements, and these are not covered by rename in #3576494: [meta] Remove references to Gin. We should probably handle these separately. For example:

Steps to reproduce

Search for gin_ outside comments and identify variables, form element names and other mentions.

git grep "form\['gin_" | sort -u
git grep "variables\['gin_" | sort -u

Proposed resolution

Identify all other Gin mentions in variables, form element names, and similar and rename these.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3584303

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

poker10 created an issue. See original summary.

poker10’s picture

poker10 commented
Issue summary: View changes

quietone made their first commit to this issue’s fork.

quietone opened merge request !15442

quietone’s picture

quietone commented
Status: Active » Needs review

Found instances with the following and changed them using sed.

git grep "form\['gin_" | sort -u
git grep "variables\['gin_" | sort -u
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

git grep "variables\['gin_" | sort -u

Think the underscore is missing them but I'm not great with grep. But I see in variables.pcss.css there are 4 variables --gin-color-text, --gin-color-focus, --gin-color-button-text, and --gin-color-button-text plus wherever they're used.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Think the underscore is missing them

Missing what?

The issue summary scopes this to 'gin_'.

smustgrave’s picture

smustgrave commented

Title says gin variables are those that I pointed out in #6 not variables?

poker10’s picture

poker10 commented

Looks like some of the gin_ strings were renamed to default_action_ instead of default_admin_?

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

So based on the title and fact it's a theme I read this as CSS variables but maybe it was just php variables. If that's the case I'm still seeing some variable names in themeHooks, example $gin_info

quietone’s picture

quietone commented
Status: Needs work » Needs review

Well, that was a silly mistake on my part. Fixed now.

smustgrave’s picture

smustgrave commented

I still see variable names starting with $gin_ in theme books

quietone’s picture

quietone commented

Since I am not seeing them, can you link to what I am missing?

quietone’s picture

quietone commented
Issue summary: View changes

In Slack @smustgrave gave this example

$gin_info = $this->themeHandler->listInfo()['default_admin']->info;
$path_prefix = '/core/themes/default_admin/';
$gin_toolbar_overrides = $gin_info['libraries-override']['toolbar/toolbar'];

Those are preceded by a "$" and not in the scope of the issue summary.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Talked to @quietone in slack and this doesn't include php variables. My comments are wrong then.

  • amateescu committed d48ba57b on 11.x 
    task: #3584303 Rename Gin variables and form element names

By: quietone...
amateescu’s picture

amateescu commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed a50f288 to main and d48ba57 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • amateescu committed a50f2889 on main 
    task: #3584303 Rename Gin variables and form element names

By: quietone...

amateescu closed merge request !15442

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.