Problem/Motivation

The following tests are failing on the release branch:

  • FunctionalJavascript\EntityEmbedTest
  • FunctionalJavascript\CardinalityTest
  • entity_browser_example\FunctionalJavascript\EntityBrowserExampleTest
  • Kernel\Plugin\FieldWidgetDisplayTest
  • FunctionalJavascript\InlineEntityFormTest

Steps to reproduce

see https://git.drupalcode.org/project/entity_browser/-/jobs/9267875

Proposed resolution

1. CardinalityTest — Fixable: method casing bug

Six calls use assertCheckBoxExistsByValue / assertCheckBoxNotExistsByValue (capital B) but the base class defines assertCheckboxExistsByValue / assertCheckboxNotExistsByValue (lowercase b). PHP method calls are case-insensitive on most setups, but PHPUnit's __call magic method dispatching can be case-sensitive. This is the likely cause.

2. EntityBrowserExampleTest — Fixable: core: 8.x in view configs

Both example view configs have core: 8.x which is invalid for Drupal 10+. Config validation during module install would fail, causing the testExampleInstall() test to crash at setUp.

3. FieldWidgetDisplayTest — Harder to diagnose remotely

The kernel test creates comment entities. Possible issues include missing schema install (comment.schema.yml), or changes to comment_type entity validation in newer Drupal.

4. EntityEmbedTest — Likely environmental

The CKEditor 5 config looks correct. This may fail due to embed/entity_embed module version incompatibility, or WebDriver timing issues with the CKEditor 5 widget. Hard to diagnose without the actual error output.

5. InlineEntityFormTest — Likely timing/AJAX issues

Uses conditional coreVersion() checks for AJAX waits. Probably flaky due to Drupal 10.2+ AJAX behavior changes.

Remaining tasks

Make a MR.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

benstallings created an issue. See original summary.

benstallings’s picture

Title: fix failing CardinalityTest » fix failing tests
Issue summary: View changes
benstallings’s picture

Issue summary: View changes

benstallings’s picture

Assigned: benstallings » Unassigned
Status: Active » Needs review

Tests are now passing! phpstan and phpcs complaints are not related to these changes.

anybody’s picture

Status: Needs review » Needs work

@benstallings are we also able to fix
previous minor and major or do we need to change the gitlab ci yml or the compatibility?

Before merging ANYTHING else, I'd like to get this one and #3541968: Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...) merged.

benstallings’s picture

Status: Needs work » Needs review

@anybody they're all passing now!

anybody’s picture

Status: Needs review » Needs work

Nice work @benstallings - I left one comment, the rest LGTM. I think it's fine to use node instead of comment for simplification.

benstallings’s picture

Assigned: Unassigned » benstallings
benstallings’s picture

Assigned: benstallings » Unassigned
Status: Needs work » Needs review
anybody’s picture

Status: Needs review » Reviewed & tested by the community

Great! All LGTM! RTBC+1

anybody’s picture

Title: fix failing tests » Fix failing tests
anybody’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.