Problem/Motivation

The update query has lacks an ORDER BY clause. The order is not deterministic without it. The insert order of domain_path to path_alias is important because \Drupal\path_alias\AliasRepository prefers newer path aliases (ORDER BY id DESC)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork domain_path-3583817

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo commented
Status: Active » Needs review

Also applies to 2.x

webflo’s picture

webflo commented
Issue summary: View changes
mably’s picture

mably commented

Hi @webflo, I’m not sure I fully understand the issue you’re pointing out. Could you provide a bit more detail on what’s not working or what behavior you’re expecting?

That said, I’m fine with merging this as is.

mably opened merge request !103

mably’s picture

mably commented

@webflo I added a small comment and an explicit sort order, is it ok for you?

mably’s picture

mably commented
Title: Add order by clause to to update hook » Add order by clause to migration update hook
webflo’s picture

webflo commented
Status: Needs review » Reviewed & tested by the community

Looks great!

  • mably committed 615637ab on 3.x 
    fix: #3583817 Add order by clause to migration update hook

By: webflo...

  • mably committed ef15ae03 on 2.x 
    fix: #3583817 Add order by clause to migration update hook

By: webflo...
mably’s picture

mably commented
Status: Reviewed & tested by the community » Fixed

Merged into 3.x and backported to 2.x.

Thanks @webflo!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.