Changes were made to Metatag 2.2.x (soon to be 2.2.1) that cause the current tests to fail.

Work out whether this is something that can be fixed in Schema Metatag or if something needs to be reverted in Metatag.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

damienmckenna created an issue. See original summary.

damienmckenna’s picture

ptmkenny made their first commit to this issue’s fork.

ptmkenny’s picture

I made a first pass at this because updating metatag to the latest dev release (April 1) caused a WSOD because I also have schema_metatag installed. My MR clears the WSOD but we should not need to change a constructor for a minor release.

damienmckenna’s picture

FYI I opened #3583643: Revert accidental API changes because there shouldn't be API breaks in 2.2.1.

damienmckenna’s picture

I fixed the API regression in MetaNameBase, hopefully everything else works correctly now too.

damienmckenna’s picture

Status: Active » Fixed

The latest MR shows that the module works correctly with Metatag 2.2.x, so this is a-ok now, we don't need to make any changes to Schema Metatag after all.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

ptmkenny’s picture

That's fine, but I needed to use the dev version of schema_metatag with the dev version of metatag; if I use the 3.0.4 version of schema_metatag with dev version of metatag, I get a WSOD:


Fatal error: Type of Drupal\schema_metatag\Plugin\metatag\Tag\SchemaNameBase::$configFactory must be omitted to match the parent definition in class Drupal\metatag\Plugin\metatag\Tag\MetaNameBase in /var/www/html/web/modules/contrib/schema_metatag/src/Plugin/metatag/Tag/SchemaNameBase.php on line 16
Stack trace: #0 /var/www/html/vendor/composer/ClassLoader.php(576): include() #1 /var/www/html/vendor/composer/ClassLoader.php(427): {closure:Composer\Autoload\ClassLoader::initializeIncludeClosure():575}() #2 /var/www/html/web/modules/contrib/schema_metatag/schema_web_site/src/Plugin/metatag/Tag/SchemaWebSiteType.php(31): Composer\Autoload\ClassLoader->loadClass() #3 /var/www/html/vendor/composer/ClassLoader.php(576): include('...') #4 /var/www/html/vendor/composer/ClassLoader.php(427): {closure:Composer\Autoload\ClassLoader::initializeIncludeClosure():575}() #5 [internal function]: Composer\Autoload\ClassLoader->loadClass() #6 /var/www/html/web/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php(96): class_exists() #7 /var/www/html/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php(17): Drupal\Component\Plugin\Factory\DefaultFactory::getPluginClass() #8 /var/www/html/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php(85): Drupal\Core\Plugin\Factory\ContainerFactory->createInstance() #9 /var/www/html/web/modules/contrib/metatag/src/MetatagManager.php(665): Drupal\Component\Plugin\PluginManagerBase->createInstance() #10 /var/www/html/web/modules/contrib/metatag/src/MetatagManager.php(607): Drupal\metatag\MetatagManager->generateRawElements() #11 /var/www/html/web/modules/contrib/metatag/metatag.module(380): Drupal\metatag\MetatagManager->generateElements() #12 /var/www/html/web/modules/contrib/metatag/metatag.module(308): metatag_get_tags_from_route() #13 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(354): metatag_preprocess_html() #14 /var/www/html/web/core/lib/Drupal/Core/Theme/ThemeManager.php(311): Drupal\Core\Extension\ModuleHandler->invoke() #15 /var/www/html/web/core/lib/Drupal/Core/Theme/ThemeManager.php(340): Drupal\Core\Theme\ThemeManager->{closure:Drupal\Core\Theme\ThemeManager::render():293}() #16 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(500): Drupal\Core\Theme\ThemeManager->render() #17 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(253): Drupal\Core\Render\Renderer->doRender() #18 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(143): Drupal\Core\Render\Renderer->doRenderRoot() #19 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(634): Drupal\Core\Render\Renderer->{closure:Drupal\Core\Render\Renderer::renderInIsolation():142}() #20 [internal function]: Drupal\Core\Render\Renderer::{closure:Drupal\Core\Render\Renderer::executeInRenderContext():634}() #21 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(649): Fiber->resume() #22 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(142): Drupal\Core\Render\Renderer->executeInRenderContext() #23 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(113): Drupal\Core\Render\Renderer->renderInIsolation() #24 /var/www/html/web/core/lib/Drupal/Core/Render/BareHtmlPageRenderer.php(79): Drupal\Core\Render\Renderer->renderRoot() #25 /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Render/BareHtmlPageRenderer.php(76): Drupal\Core\Render\BareHtmlPageRenderer->renderBarePage() #26 /var/www/html/web/core/includes/install.core.inc(1069): Drupal\Core\ProxyClass\Render\BareHtmlPageRenderer->renderBarePage() #27 /var/www/html/web/core/includes/install.core.inc(161): install_display_output() #28 /var/www/html/web/core/install.php(53): install_drupal() #29 {main}

So the next version of schema_metatag may need to require the next version of metatag.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.