ma

Problem/Motivation

@andypost has built a PHP 8.6 image.

Proposed resolution

Start executing core and component Unit tests with PHP 8.6.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#17 3582508-nr-bot_0vx7_c5e.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3582508

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Version: 11.x-dev » main

mondrake opened merge request !15301

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Agree probably good to start this as I imagine 8.6 will land while D12 is out.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This isn't adding a nightly test, it's adding it to every run, e.g. https://git.drupalcode.org/project/drupal/-/merge_requests/15301/pipelines

I

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: [CI] Run Unit tests on PHP 8.6 nightly » [CI] Run Unit tests on PHP 8.6
Status: Needs work » Needs review

It is targeting the nightly build of PHP 8.6, not the daily job of Drupal :)

I think it should be like this - otherwise how would we fix PHP deprecations that may come later?

Probably the question would be if it's right to start testing now on 8.6 or rather wait for later in their dev cycle.

catch’s picture

catch
he/him
Primary language English
commented

Oh I see, but the job is currently failing and the entire pipeline shows with a warning. I think we'd want allow_fail or similar?

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes

The job is allowing failures already - and it’s failing. The effect is a warning sign and not an error sign in the pipeline job report. The pipeline itself is green - becase some job that were allowed to fail, failed. We had the same behavior while testing Php 8.5 last year before its GA and support.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I think we can fix few tests here same time as enabling testing

- https://php.watch/versions/8.6/json_decode-error-position already commited and needs simple fix
- PhpRequirements also could add EOL date as 8,6 roadmap already defined

andypost’s picture

andypost
he/him
Primary language Russian
commented

remaining 2 failures are pass with opcache.enable_cli=0 so probably I need to file upstream issue

andypost’s picture

andypost
he/him
Primary language Russian
commented

@mondrake would be great to finish https://github.com/php/php-src/pull/10050

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

10-12 are actually confirming this is good at spotting early PHP 8.6 problems that may impact us, so returning to RTBC

#12 for sure, sorry I cannot help though

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Needs review

Reported upstream https://github.com/php/php-src/issues/21691

NR for attempt to fix by disabling opcache in CLI and fixed https://github.com/krakjoe/apcu/pull/616 to make new image build

andypost’s picture

andypost
he/him
Primary language Russian
commented

upstream created PR so I rebuild images and only polishing of "EXIT_CODE" usage left

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Great @andypost - so it's all green now. I'd let this in now, so when new PHP 8.6 builds bring gaps, we can spot them early enough.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3582508-nr-bot_0vx7_c5e.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Reviewed & tested by the community

rebased

  • catch committed 6e3134ab on main 
    task: #3582508 [CI] Run Unit tests on PHP 8.6

By: mondrake
By: andypost
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Sorry for the wrong turns here but also thanks for fixing the known issues, good to start with a green run.

Committed/pushed to main, thanks!

Do we want to backport this to 11.x or do a larger backport later on when things are a bit more settled? Moving to 'fxed' for now.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Do we want to backport this to 11.x or do a larger backport later on when things are a bit more settled?

I think at this stage it's just fine to keep PHP's edge with our dev edge.

mondrake closed merge request !15301

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.