EntityUsageTrackBase::trackOnEntityUpdate() currently detects “new revision” by comparing revision IDs with $source_entity->original.
The proposed change uses isNewRevision() as the primary signal. This is a better and more explicit way to detect revision creation, independent from original state.

Issue fork entity_usage-3582425

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gugalamaciek created an issue. See original summary.

gugalamaciek opened merge request !176

gugalamaciek’s picture

gugalamaciek commented
Assigned: gugalamaciek » Unassigned
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Does this actually cause any issues? Isn't it more of a task?

alexpott opened merge request !214

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.x-2.x-dev » 5.x-dev
Category: Bug report » Task

Given this is not fixing a bug I think we can treat this as a task and only fix in 5.x

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 59e64e84 on 5.x 
    task: #3582425 Use isNewRevision() in EntityUsageTrackBase::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.