Problem/Motivation

The module currently doesn't use the canonical URL of the entity but the rewritten URL to link it.
This is risky if the (rewritten) URL changes and should be configurable. Instead, by default, we should use the canonical URL (e.g. /node/123 for nodes) like LinkIt does for the same reasons.

These URLs will be rewritten nevertheless.

https://git.drupalcode.org/project/ckeditor_mentions/-/blob/3.0.x/src/Me...

Steps to reproduce

Proposed resolution

Add a setting "Use rewritten URL as href" with a clear description and disable it by default.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor_mentions-3582357

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Needs review

All done. Please review!

grevil opened merge request !45

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Needs review » Needs work

@grevil needs an update hook to set the value to TRUE for all existing installations to not BC!

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Now we need to add an update hook from the old one for not breaking BC

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Reviewed & tested by the community

All resolved, thanks @grevil!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • anybody committed 28cc3309 on 3.0.x authored by grevil 
    feat: #3582357 Use the entity canonical path instead of the (rewritten)...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.