Problem/Motivation

Found an ignore line that was not necessary.

Steps to reproduce

Proposed resolution

Remove the cspell:ignore and spellcheck the theme. Make changes as needed.
Besides fixing spelling in the theme description also reword it to match the style of simplicity of the ones for Olivero and Claro.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3582169

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !15276

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

lol idk if it's lucky or unlucky but think you hit every random test failure!

This one was pretty straight forward. Not a lot of cspell:ignores. Funny enough is-autocompleting is in claro and some nightwatch tests imagine that's where that line came from.

Your description change made me think should all references to gin be removed? Some of it is variable names.

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Needs review

Small question on the MR :)

smustgrave’s picture

smustgrave commented

Can I ask if there's a command you run to find these words or just history knowledge from previous tickets?

quietone’s picture

quietone commented

For this issue I did what I wrote in the proposed resolution. I removed all the cspell ignore lines in the them and then ran the spellcheck, yarn spellcheck:core.

There is also #3390959: Test for words in 'cspell:ignore' that can be removed which adds commands to commit-code-check.sh and will report on words that can be removed.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Think this is a nice little cleanup then.

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 51366e68418 to main and f8c5c1010ff to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 51366e68 on main 
    task: #3582169 Cleanup cspell ignores in Admin

By: quietone
By:...

quietone closed merge request !15276

  • alexpott committed f8c5c101 on 11.x 
    task: #3582169 Cleanup cspell ignores in Admin

By: quietone
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.