The All News view does not have the word Search in the keyword input and needs to be added for accessibility

Issue fork healthcare-3581934

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kerrymick created an issue. See original summary.

kerrymick’s picture

kerrymick commented
Issue summary: View changes

kerrymick opened merge request !17

kerrymick opened merge request !18

kerrymick changed the visibility of the branch 3581934-add-placeholder-text to hidden.

kerrymick closed merge request !17

kerrymick changed the visibility of the branch 3581934-add-placeholder-text to active.

kerrymick’s picture

kerrymick commented
Status: Active » Needs review

nkarhoff made their first commit to this issue’s fork.

schillerm’s picture

schillerm commented
Status: Needs review » Reviewed & tested by the community

Hi there, I reviewed MR!18. To be honest the hardest bit was the set up using the issue branch as I normally work on issues related to modules. It's a cool recipe.
I worked it out, and the recipe successfully installed with the Search news label showing on the /news page.
I ran WAVE against the page, the search input had "A form label is present and associated with a form control." associated with it. So accessibility checks are good, WAVE is happy.
It's such a simple config change, so moving to RTBC.

kerrymick’s picture

kerrymick commented
Status: Reviewed & tested by the community » Fixed

Thanks @nkarhoff and @schillerm. Merging now.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • kerrymick committed fe863e1f on 1.x 
    Edit views.view.all_news.yml #3581934 Add placeholder text for Search...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.