Problem/Motivation

In the https://www.drupal.org/project/text_resize/issues/3581614 GitLab pipelines were introduced. Currently, stylelint and ESLint jobs are failing.

Steps to reproduce

Check pipelines.

Proposed resolution

Fix it.

Issue fork text_resize-3581626

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vitaliyb98 created an issue. See original summary.

vitaliyb98 opened merge request !15

vitaliyb98’s picture

vitaliyb98 commented
Assigned: vitaliyb98 » Unassigned
Status: Active » Needs review

Fixed stylelint and eslint jobs

vinodhini.e’s picture

vinodhini.e commented

Hi, Tested this on Drupal 10.5.1 and ran coding standards for ESLint and Stylelint.

Initially faced issues in both ESLint and Stylelint.
Applied MR !15 and re-ran the reports.

ESLint issues are resolved.

Still seeing 4 Stylelint issues related to ID selector naming (kebab-case):

web/modules/contrib/text_resize/css/text_resize.css
6:2 Expected id selector "#text_resize_increase" to be kebab-case
18:2 Expected id selector "#text_resize_reset" to be kebab-case
30:2 Expected id selector "#text_resize_decrease" to be kebab-case
42:1 Expected id selector "#text_resize_clear" to be kebab-case

These issues still need to be addressed. Thanks.

vitaliyb98’s picture

vitaliyb98 commented

@vinodhini.e thanks for your review!

I'm not sure it's a good idea to rename #text_resize_increase to #text-resize-increase, since users may already have styles bound to this ID. Also, GitLab pipelines don’t report this as an issue (regarding kebab-case).

vinodhini.e’s picture

vinodhini.e commented

@vitaliyb98, Thanks for the clarification.

Agree that renaming the IDs could cause backward compatibility issues if existing sites are using them.

Also, since this is not reported in GitLab pipelines, it may not be required to fix now.

So it’s fine to keep the current implementation. Thanks.

vitaliyb98’s picture

vitaliyb98 commented
Status: Needs review » Reviewed & tested by the community

Thanks!

vitaliyb98’s picture

vitaliyb98 commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.