Problem/Motivation

Pipeline is currently broken, needs to be fixed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork twig_tweak-3581423

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

@grevil could you have a look if you see the reason?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@grevil this is VERY interesting IMHO (also for our docs): #3578759: Fix GitLab pipelines (tests, phpstan, phpcs, cspell) and reduce waste

anybody opened merge request !81

anybody opened merge request !82

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@grevil the gitlab-ci.yml configuration here might even be smarter! Really nice learnings!!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Fix broken CI Pipeline / tests » Fix broken CI Pipeline / tests and only allow non-important tests to fail
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Looking at the tests this seems to be broken since about Dez 2024?

https://git.drupalcode.org/project/twig_tweak/-/commits/3.x?ref_type=heads

grevil made their first commit to this issue’s fork.

grevil closed merge request !81

grevil changed the visibility of the branch 3581423-3.x to hidden.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Needs review

Should be fixed now, the key order was the problem, as "PHPUnitAssert::assertSame" also asserts the array key correct order.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@grevil: I think it doesn't make sense to compare the order? Let's fix that!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I suggest you fully disable testing on Drupal 12 ("next major") until you are making a branch for D12 compatibility.

Getting tests to pass on Drupal 11.4 ("next minor") will also be important soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.