Problem/Motivation

command -:
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/twig_tweak/

FILE: /var/www/html/d10/web/modules/contrib/twig_tweak/docs/migration-to-3.x.md
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
39 | WARNING | Line exceeds 80 characters; contains 210 characters
-------------------------------------------------------------------------------

FILE: /var/www/html/d10/web/modules/contrib/twig_tweak/docs/cheat-sheet.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 20 WARNINGS AFFECTING 20 LINES
--------------------------------------------------------------------------
8 | WARNING | Line exceeds 80 characters; contains 101 characters
13 | WARNING | Line exceeds 80 characters; contains 84 characters
31 | WARNING | Line exceeds 80 characters; contains 90 characters
36 | WARNING | Line exceeds 80 characters; contains 134 characters
37 | WARNING | Line exceeds 80 characters; contains 91 characters
85 | WARNING | Line exceeds 80 characters; contains 101 characters
86 | WARNING | Line exceeds 80 characters; contains 154 characters
87 | WARNING | Line exceeds 80 characters; contains 99 characters
89 | WARNING | Line exceeds 80 characters; contains 97 characters
92 | WARNING | Line exceeds 80 characters; contains 111 characters
122 | WARNING | Line exceeds 80 characters; contains 113 characters
124 | WARNING | Line exceeds 80 characters; contains 88 characters
162 | WARNING | Line exceeds 80 characters; contains 148 characters
168 | WARNING | Line exceeds 80 characters; contains 86 characters
200 | WARNING | Line exceeds 80 characters; contains 89 characters
205 | WARNING | Line exceeds 80 characters; contains 82 characters
281 | WARNING | Line exceeds 80 characters; contains 88 characters
294 | WARNING | Line exceeds 80 characters; contains 162 characters
296 | WARNING | Line exceeds 80 characters; contains 104 characters
372 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------

FILE: /var/www/html/d10/web/modules/contrib/twig_tweak/docs/blocks.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
20 | WARNING | Line exceeds 80 characters; contains 109 characters
58 | WARNING | Line exceeds 80 characters; contains 81 characters
108 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------

Steps to reproduce

Run PHPCS on Config Pages module.

Proposed resolution

Fixed the coding standards.

Remaining tasks

Submit the patch either MR.

CommentFileSizeAuthor
#10 twig-tweak_MR!53-passed.png43.42 KBroberttabigue

Issue fork twig_tweak-3458447

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Hetal.Solanki created an issue. See original summary.

Hetal.Solanki opened merge request !53

hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Issue tags: +Coding standards
bhaveshdas’s picture

bhaveshdas commented
Status: Needs review » Reviewed & tested by the community

I have tested and cannot find any phpcs issue so I move forward to RTBC

chi’s picture

chi commented
Status: Reviewed & tested by the community » Closed (works as designed) 
{ node|entity_link('Add new comment'|t, 'canonical',
fragment: 'comment-form'}) }}

Don't you think it looks weird? That's why Twig Tweak uses own PHPCS configuration.

zaryab_drupal’s picture

zaryab_drupal commented
Status: Closed (works as designed) » Active
zaryab_drupal’s picture

zaryab_drupal commented
Version: 3.3.0 » 3.4.0

liam morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 3.4.0 » 3.x-dev
Status: Active » Needs review

These may be good changes to make, but they are not needed for phpcs, which is already passing.

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new twig-tweak_MR!53-passed.png43.42 KB

Hi,

I have applied the latest MR !53 to the Twig Tweak module (3.x-dev) on my Drupal 10 local setup and confirmed all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml twig_tweak

Please see the attached file for reference.

I'm moving this now to "RTBC".

Thank you!

anybody made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@liam morland unsure if this is outdated looking at the pipeline status for 3.x and 4.x (first glance)?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 3.x-dev » 4.x-dev
Status: Reviewed & tested by the community » Needs work
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

phpcs is passing on 3.x and 4.x so this can be closed.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Closed (outdated)

Thanks @liam morland!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.