Problem/Motivation

The FacetSource entity defines a non-existent form handler in its annotation on line 20:
"display" = "Drupal\facets\Form\FacetSourceDisplayForm".

Steps to reproduce

Check the source code:
https://git.drupalcode.org/project/facets/-/blob/3.0.x/src/Entity/FacetS...
then check that there is no FacetSourceDisplayForm in the Form folder:
https://git.drupalcode.org/project/facets/-/tree/3.0.x/src/Form

Proposed resolution

Either remove the reference to the non-existent form or implement it.

Issue fork facets-3581350

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

morvaim created an issue. See original summary.

morvaim’s picture

morvaim commented
Issue summary: View changes
aayushpathak’s picture

aayushpathak commented

working on it

aayushpathak opened merge request !367

aayushpathak’s picture

aayushpathak commented
Status: Active » Needs review

The FacetSource entity defined a "display" form handler pointing to
FacetSourceDisplayForm, which does not exist in the codebase.
Removed the invalid handler to avoid runtime errors.

morvaim’s picture

morvaim commented
Status: Needs review » Reviewed & tested by the community

Thanks! I think, the tests are failing because of this issue: https://www.drupal.org/project/facets/issues/3581854, so that is not related, otherwise LGTM.

strykaizer made their first commit to this issue’s fork.

  • strykaizer committed fd64412b on 3.0.x 
    Issue #3581350: Remove invalid FacetSourceDisplayForm handler reference.
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

aayushpathak’s picture

aayushpathak commented

Hi,
I noticed the issue has been marked as fixed ,thanks for the review.
Could we please add and distribute the contribution credit accordingly?
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.