Problem/Motivation

diff module now has a 2.1 branch that has awesomeness and security advisory fixes. WxT calls for 1.x

Evaluated diff 2.1 and it's a huge improvement.

Justification:
We're looking for revision diff on block content revisions.

See screenshot of upgraded UI

Upgraded ui for diff 2x with block content revision patch

Steps to reproduce

TBD

Proposed resolution

Drop all current diff patches in wxt composer.json

  1. Switch from diff 1x to diff (^2.1)
  2. Drop all previous diff module patches, they are no longer needed.

Remaining tasks

TBD

User interface changes

TBD

API changes

TBD

Data model changes

TBD

CommentFileSizeAuthor
#3 diff2x_block_content_revision_diff-2452523-70.patch64 KBjoseph.olstad
#2 diff2x_with_2452523-MR112.png61.35 KBjoseph.olstad

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
StatusFileSize
new diff2x_with_2452523-MR112.png61.35 KB
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
StatusFileSize
new diff2x_block_content_revision_diff-2452523-70.patch64 KB

patch I'm using:

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » smulvih2
Category: Support request » Feature request
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Related issues: +#2452523: Offer a revisions tab for all entities

@joseph can you post this patch to the related drupal/diff issue so we can use a patch referenced from that issue please?

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs review » Needs work
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

#2452523-70: Offer a revisions tab for all entities

should be sufficient issue in the patch number matches comment 70 for issue 2452523

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I just sent this message to #maintainers channel in Slack

https://drupal.slack.com/archives/CJ93UNJP4/p1774369798837489

Attention maintainers of the diff project: @dww @acbramley @heddn @miro_dietiker @juampynr @phenaproxima https://www.drupal.org/project/diff/issues/2452523 11 year issue, everyone desperately needs this merged for revision diff on content blocks and other entity types. I recommend merging this. The module is currently at 2.0.0-beta5, could cut another beta or rc tagged release.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Go with the patch, got some feedback via Slack.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Needs work
Issue tags: +Needs merge request
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: diff module upgrade » Security: Update to diff 2
Category: Feature request » Task
Issue tags: +Security improvements
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes

No longer need any patches, the awesomeness is in ^2.1

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs merge request

No need for a merge request, this will be an easy change to do.
Just drop the diff patches in drupalwxt composer.json
switch from 1x to ^2.1
done deal.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: smulvih2 » Unassigned
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Security: Update to diff 2 » Security: Update to diff 2.1
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes