Problem/Motivation

drupal_token() documentation / example missing for passing attributes

@chi once posted an example in #2845318: drupal_token function does not support passing in the $data argument. Let's add it to the README.md!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork twig_tweak-3580909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !79

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review

@chi: I created the MR against 4.x - should be cherry-picked into 3.x then.
Hope it's all correct?

Thanks!!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

PS: Failing tests are - of course - unrelated

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

LGTM

chi’s picture

chi commented

Hey @anybody. I have little time these days to properly maintain this module. Would you like to become a co-maintainer?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Hi @chi if you're fine with that, I am also! Would you also be fine to add my team-mate @grevil as backup?

We won't do large changes here without your very much appreciated feedback.

chi’s picture

chi commented

We won't do large changes here without your very much appreciated feedback.

I don't think I will have enough time for review. Honestly, I am not using this module myself. Just be careful about BC breaks in minor releases. The module has quite a lot of installations.

Granted access to @anybody and @grevil. Feel free to commit anything you think is appropriate.

@chesn0k may help with this as well.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3581423: Fix broken CI Pipeline / tests and only allow non-important tests to fail

Broken tests are unrelated, see #3581423: Fix broken CI Pipeline / tests and only allow non-important tests to fail
Merging the documentation additions.

  • anybody committed fb85f06c on 4.x 
    feat: #3580909 drupal_token() documentation / example missing for...

  • anybody committed f5ed587f on 3.x 
    feat: #3580909 drupal_token() documentation / example missing for...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chi’s picture

chi commented

FYI, @ChesnOk currently has no time for this project. I removed him from the list of maintainers. I also added the "Administer maintainers" permission to @anybody in case there is a need to add a new co-maintainer.

As there is a lot of activity now in issues that I am not participating in, I have unsubscribed from email notifications for this project. Ping me on Slack if needed.

Glad to see the project moving forward. Thank you!