Problem/Motivation

mglaman/phpstan-drupal has a new release

Proposed resolution

  1. composer update mglaman/phpstan-drupal phpstan/extension-installer phpstan/phpstan phpstan/phpstan-deprecation-rules phpstan/phpstan-phpunit spaze/phpstan-disallowed-calls
  2. update manually the constraints to latest versions
  3. composer update --lock

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3580747

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake changed the visibility of the branch 3580747-bump-phpstan- to hidden.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Version: 11.x-dev » main

mondrake opened merge request !15165

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Priority: Major » Normal
smustgrave’s picture

smustgrave commented

Random why did those baseline changes popup? They seem like valid checks still? New rule?

mondrake’s picture

mondrake
Location 🇮🇹
commented

#7 it could be new stubs in mglaman/phpstan-drupal and changes to phpstan code analysis for the no longer undefined variables. In other words, it's upstream improvements.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Interesting but if that's what it says that's what it says. Thanks for keeping up with these btw.

  • catch committed 479d8d14 on main 
    task: #3580747 Bump PHPStan & friends to latest release

By: mondrake
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

This will need a backport for 11.x, although to be honest I'm not sure why we wouldn't do it in bulk with other dependency updates during beta. So marking fixed against main for now.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !15165

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +PHPStan