Problem/Motivation

mglaman/phpstan-drupal will now allow PHPStan to parse property hooks https://github.com/mglaman/phpstan-drupal/releases/tag/2.0.11

Proposed resolution

  1. composer update mglaman/phpstan-drupal phpstan/extension-installer phpstan/phpstan phpstan/phpstan-deprecation-rules phpstan/phpstan-phpunit
  2. update manually the constraints to latest versions
  3. composer update --lock

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575792

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !14912

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

Merge conflict, if this gets rebased and I see it I will try to get it in ASAP. We will likely need separate MRs for main and 11.x as well.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Rebased for main.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Reviewed & tested by the community

Pipeline creation fails, though :(

mondrake opened merge request !15059

mondrake’s picture

mondrake
Location 🇮🇹
commented

MR !15059 is for 11.x

Weird error reported by PHPStan though:

------ --------------------------------------------------------------- 
  Line   core/modules/sqlite/src/Driver/Database/sqlite/Connection.php  
 ------ --------------------------------------------------------------- 
  224    Non-capturing catch is supported only on PHP 8.0 and later.    
 ------ ---------------------------------------------------------------

We're well above PHP 8 so I think this could be a PHPStan bug.

Just added a variable and silenced the counterpart PHPCS error in 11.x.

MR!14912 is for main, and has a JStest failure seemingly unrelated.

  • longwave committed 61d16812 on main 
    task: #3575792 Bump PHPStan & friends to latest release

By: mondrake

longwave closed merge request !14912

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 878ea540 on 11.x 
    task: #3575792 Bump PHPStan & friends to latest release

By: mondrake

longwave closed merge request !15059

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.