The main site where I'm using Forward doesn't actually have a logo. 😅 They just use text with a specific font, and that's more appropriate for their needs than a graphic. However, template_preprocess_forward() is currently written to assume there must be a logo.
Install forward on a site where neither the forward_email_logo setting nor theme_get_setting('logo.url') have a value. Try to forward anything. Behold:
Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\Component\Utility\UrlHelper::isExternal() (line 271 of core/lib/Drupal/Component/Utility/UrlHelper.php).
Deprecated function: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\Component\Utility\UrlHelper::isExternal() (line 273 of core/lib/Drupal/Component/Utility/UrlHelper.php).
Relevant backtrace is:
Drupal\Component\Utility\UrlHelper::isExternal() (Line: 113)
template_preprocess_forward()
...
Handle the case that there is no logo inside template_preprocess_forward()
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3579010-2.patch | 1.1 KB | dww |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !9
Comments
Comment #2
dwwSince there's no
.gitlab-ci.ymlhere (yet), uploading as a raw patch for now.Comment #6
dww