Problem/Motivation

Maintainer list, slack channel, google group and core permissions were not updated with #3556948: Merging Gin as Admin theme.

Steps to reproduce

Proposed resolution

See the missing steps at https://www.drupal.org/about/core/policies/maintainers/add-or-remove-a-s...

  • ◻ See MR: Add Admin theme to maintainers.txt with Sacha and Jürgen as maintainers.
  • ☑ Add Jürgen to Slack channel for core maintainers
  • ☑ Add Jürgen to project maintainer list on drupal.org
  • ☑ Add Jürgen to maintainers google group (mailing list)

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3578745

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gábor hojtsy created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I added @jurgenhaas to the Slack channel.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I added @jurgenhaas to https://www.drupal.org/node/3060/maintainers. I think all is left then is the maintainers.txt file.

gábor hojtsy opened merge request !15072

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Add maintainers of Admin theme to core maintainer list, project permissions and slack channel » Add maintainers of Admin theme to core maintainer list, project permissions, slack channel and google group
Issue summary: View changes

There is also the maintainer google group per https://www.drupal.org/about/core/policies/maintainers/add-or-remove-a-s... which I don't seem to have access to manage somehow from either of my google accounts I tried. Added this as task above.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review

Marking needs review for the MR.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

Ah, found the "Drupal Core Subsystem and Topic Maintainers" mailing list member management through a different URL from the one shared in the doc. Added Jürgen there. So only this MR is left now.

smustgrave’s picture

smustgrave commented

@jurgenhass can you confirm you've read and understand

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

@smustgrave I can confirm that I've read through the links you listed in #8. I understand the policies and will adhere to them.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks! Happy to have ya aboard.

quietone’s picture

quietone commented
Assigned: Unassigned » quietone

I'll look at this before sometime in the next 8 hours.

quietone’s picture

quietone commented
Title: Add maintainers of Admin theme to core maintainer list, project permissions, slack channel and google group » Add maintainers of Admin theme to MAINTAINERS.txt

  • quietone committed 9cd5689e on main 
    task: #3578745 Add maintainers of Admin theme to MAINTAINERS.txt

By:...

  • quietone committed c5100f35 on 11.x 
    task: #3578745 Add maintainers of Admin theme to MAINTAINERS.txt

By:...

  • quietone committed 66ffb960 on 11.3.x 
    task: #3578745 Add maintainers of Admin theme to MAINTAINERS.txt

By:...
quietone’s picture

quietone commented
Assigned: quietone » Unassigned
Status: Reviewed & tested by the community » Patch (to be ported)

I removed the parentheses around "theme" in the title because they seemed unnecessary to me.

Doesn't apply to 10.6.x

quietone’s picture

quietone commented
Version: main » 10.6.x-dev
smustgrave’s picture

smustgrave commented

Is a 10.6 MR needed? Don’t think the admin theme was added in 10

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 10.6.x-dev » 11.x-dev
Status: Patch (to be ported) » Fixed

Yep I think this only needs to go into 11.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gábor hojtsy closed merge request !15072