Problem/Motivation

This came up in our performance tests. The logic causes at least two additional queries, possibly a lot more with access checks and so on.

Steps to reproduce

Proposed resolution

Multiple things.

1. Instead of querying for the blocks, I think we can reliably get the from $variables['page']['navbar'], that should reliably contain the blocks we are looking for. In theory it could also contain other stuff, but then it shouldn't get loaded, that should be Ok.

2. Cache the information, probably by menu and active trail for it. To be implemented

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork bs_base-3578665

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

berdir opened merge request !32

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

pivica made their first commit to this issue’s fork.

  • pivica committed 73993e30 on 2.0.x authored by berdir 
    task: #3578665 Performance improvements for bs_base_preprocess_page()...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

pivica’s picture

pivica commented
Version: 2.x-dev » 2.0.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.