Problem/Motivation

This is a follow-up to #3397041: Autowire core modules that do not require explicit configuration.

Autowire Core module services that need to have #[Autowire(...)] attributes applied to constructor parameters.

Proposed resolution

Apply the patch that I attached to #3397041-21: Autowire core modules that do not require explicit configuration.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3578374-nr-bot_3dchyn9a.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3578374

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dcam created an issue. See original summary.

dcam opened merge request !15047

dcam’s picture

dcam commented
Status: Active » Needs review

I think the build test error is random.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs review » Needs work

Merge conflicts must be resolved.

dcam’s picture

dcam commented
Status: Needs work » Needs review

Rebased

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs review » Needs work

This is not mergeable owing to git conflict.

dcam’s picture

dcam commented
Status: Needs work » Needs review
dcam’s picture

dcam commented

I got a suggestion that deleting the constructor docblocks might be allowed (or possibly be insisted upon) as being in-scope. The most recent commit can be reverted if not.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

@dcam pinged me about this in slack. Thanks for deleting those docs :)

I did start a new pipeline to see if the test was random as not use to seeing random unit failures but it was random.

I truly have no feedback on this one other then fantastic work! Happy to mark for you.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3578374-nr-bot_3dchyn9a.txt91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

dcam’s picture

dcam commented
Status: Needs work » Reviewed & tested by the community

Rebased due to a new service added to BigPipeResponseAttachmentsProcessor.

godotislate’s picture

godotislate
he/him
commented

I have gone back and forth about whether scope should include adding property promotion wherever possible here. On one hand, it's increased scope, but on the other hand, it will take a long time to do property promotion on all these classes.

dcam’s picture

dcam commented
Status: Reviewed & tested by the community » Needs review

I discussed the property promotion with @godotislate in Slack and agreed to implement it.

dcam’s picture

dcam commented

I'm pretty sure those failures are random. They pass locally for me. And package_manager is known for causing problems right now. But it would be good if someone who can re-run tests would do that for the update module test.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think there is a Rector rule to implement property promotion, it's the sort of thing we could do across all code in a beta window if we wanted to. (Beta windows are good for large scale changes that would conflict with other large feature MRs, because we're not trying to land features during beta)

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Dcam pinged about this one and seems like the constructor promotion is done.

Do we need a follow up for running a rector rule?

catch’s picture

catch
he/him
Primary language English
commented

#3278431: [May 2026] Use PHP 8 constructor property promotion for existing code is the rector property promotion issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a24f668 and pushed to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed a24f6682 on main 
    task: #3578374 Autowire core modules that require explicit configuration...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.