h5p-core v 1.28 has been released (found by composer at https://packagist.org/packages/h5p/h5p-core). When updating an existing site or installing the drupal h5p module for the first time, composer will select that version, which will cause the following error:
Fatal error: Class Drupal\h5p\H5PDrupal\H5PDrupal contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (H5PFrameworkInterface::resetHubOrganizationData) in /var/www/html/web/modules/contrib/h5p/src/H5PDrupal/H5PDrupal.php on line 12
on a site that has never had the module installed:
There may be other orders of operation that encounter the same issue.
A similar thing happened when H5P Core 1.27 was released: Issue #3477835, which was deemed to have been a result of the 1.27 upgrade, as addressed in Issue #3497789.
Since the answer at that time was to stub out the missing method from the interface, I will attempt the same thing here.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | h5p-stub-resetHubOrganizationData-3578071-1.patch | 501 bytes | mreda |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
ldpm commentedMR submitted
Comment #4
mreda commentedComment #5
pjotr.savitski commentedThis change gets things working again.
Comment #6
ryan-l-robinson commentedPatch seems to have fixed the problem for me as well.
Comment #7
ammaletu commentedShouldn't all the stub methods be filled with functionality at some point? But for what it's worth, the patch gets pages with H5P content from white-screen-of-death back to working. And since there are already four other stub methods, this won't hurt.
I'm taking the liberty to set this to RTBC as three people reviewed the patch now. Also, seeing how this completely breaks pages with H5P content, I'm setting the priority to Major. Merging this and tagging a new release would be preferable to everyone having to add a patch file.
As to the reason why this happened, twice: If the module implements an interface from h5p/h5p-core and this interface can change between version 1.27 and 1.28, then I think "^1.27" in composer is not sufficient. This should either be "^1.27.0" or "1.27". The module maintainers then should update the version manually, once they are sure that there are no breaking changes in the new h5p/h5p-core version.
Comment #8
ammaletu commentedThis also seems to send cron runs into a loop. In production, where the patch is not yet enabled, I see more than one cron run per minute (instead of one every 20 minutes), never getting farther than the h5p_cron (obviously). So this can break sites which only have the module enabled, even if there is no H5P content.
Comment #9
chamilsanjeewa commentedThis fixed the problem
Comment #10
c-logemannThe module blocks cron run and can't even be uninstalled with this error. #4 patch tested and used in productive system to fix. So: RTBC +1
Comment #11
dkmishra commentedI can confirm this issue affects both install and uninstall on Drupal 11. Running either `drush en -y h5p` or `drush pmu h5p` results in the fatal error described above due to the missing `resetHubOrganizationData()` method.
Tested with Drupal 11.x, PHP 8.3, h5p/h5p-core 1.28.
After applying the #4 patch, both `drush en -y h5p` and `drush pmu h5p` complete successfully without errors. RTBC +1
Comment #12
frobI think a better fix is, in
composer.jsonchange the h5p-core version requirement.