Problem/Motivation

We need kernel tests for connector plugins.

Once we have those, we can refactor.

Steps to reproduce

Proposed resolution

Start with DrupalRest.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork l10n_server-3577854

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

donquixote created an issue. See original summary.

donquixote opened merge request !115

donquixote’s picture

donquixote commented
Status: Active » Needs review

This may need a second opinion on some adventurous design choices I made with these tests :)

donquixote’s picture

donquixote commented

I created a new class EntitiesCensus to track entities. This is nicer than the trait I had before.

donquixote’s picture

donquixote commented

Opinions and thoughts are still welcome, but this needs work.
At least I need to test the scan functionality that creates new projects and releases.

donquixote’s picture

donquixote commented

We should have a test release that also creates some bugs.
And something for Drupal 7.
Suggestions welcome.

donquixote’s picture

donquixote commented

Ok, I added tests with the example files found in potx.
The code is currently not working 100% correctly, I have fixes waiting for another issue.

pierregermain’s picture

pierregermain commented

Reviewed MR !115. Tests pass.

  • Two inline suggestions left on the MR.
  • Minor: several @todo in DrupalRestConnectorTest.php; when do we work on these?

RTBC pending the two inline suggestions.

donquixote’s picture

donquixote commented

Fixed both items.

We still need to determine if maybe we want to keep the test with pathauto.
Maybe the examples from potx are enough.

donquixote’s picture

donquixote commented

I simplified, leaving only the test with the potx examples.
The subsequent calls are not tested, but this is ok.

pierregermain’s picture

pierregermain commented
Status: Needs review » Reviewed & tested by the community

MR looks good (RTBC). Thank you donquixote.

  • fmb committed efc2b3c3 on 3.0.x 
    Merge branch '3577854-tests-for-connector-plugins' into '3.0.x'

Resolve...

  • donquixote committed 4cfd61af on 3.0.x 
    Issue #3577854: Testing: Add DrupalRestConnectorTest for...

  • donquixote committed bdce844f on 3.0.x 
    Issue #3577854: Fix: Support NULL values from potx_status() messages.

  • donquixote committed 62e7bc8f on 3.0.x 
    Issue #3577854: Add some documentation on ConnectorInterface.

  • donquixote committed 6a307ce6 on 3.0.x 
    Issue #3577854: Let ConnectorManagerInterface extend...

  • donquixote committed 8a26ca39 on 3.0.x 
    Issue #3577854: Create service aliases for ParserService and...

  • donquixote committed bc4399ec on 3.0.x 
    Issue #3577854: Remove leftover composer.json in l10n_server subdir.

  • donquixote committed 706ebc01 on 3.0.x 
    Issue #3577854: Set PROJECT_NAME and PROJECT_TYPE in .gitlab-ci.yml.
fmb’s picture

fmb commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

donquixote’s picture

donquixote commented

Thanks @fmb!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.