Problem/Motivation

The icons for the theme are not rendering due to having the path hardcoded to /themes/custom, when in most instances the theme will be installed as contrib

Steps to reproduce

- Install the theme either manually as a contrib theme or via the Archimedes site template (https://www.drupal.org/project/archimedes/)
- Add any component with an icon (like quick links)
- Check that the icon doesn't render due to the wrong path

Proposed resolution

Update the path both in icon.twig and eureka.icons.yml so it's not hardcoded to the custom themes directory

Issue fork eureka-3577572

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dabodia created an issue. See original summary.

dabodia opened merge request !2

dabodia’s picture

dabodia commented
Status: Active » Needs review
nexusnovaz’s picture

nexusnovaz commented
Status: Needs review » Needs work
dabodia’s picture

dabodia commented

Thanks for the feedback! Updated both in the last commit and both still work while allowing people to change the theme name if they do copy it

dabodia’s picture

dabodia commented
Assigned: dabodia » Unassigned
Status: Needs work » Needs review
nexusnovaz’s picture

nexusnovaz commented
Status: Needs review » Reviewed & tested by the community

LGTM. Happy for it to be merged in.

nexusnovaz’s picture

nexusnovaz commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.