Problem/motivation

One of the automated tests is unreliable. Sometimes it passes, and sometimes it fails, even when there are no code changes. When I run the test locally, it sometimes fails on different lines.

Steps to reproduce

Run the test locally:

phpunit -c core modules/layout_builder_restrictions/modules/layout_builder_restrictions_by_region/tests/src/FunctionalJavascript/BlockPlacementDenylistTest.php

Or look at the pipelines for this project.

Proposed resolution

Issue fork layout_builder_restrictions-3577430

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benjifisher created an issue. See original summary.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Assigned: Unassigned » mark_fullmer

mark_fullmer opened merge request !48

mark_fullmer opened merge request !49

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Active » Fixed

Well, after adding some more waitForText() statements the tests are significantly more stable: all tests pass now on multiple runs, though I'm not convinced there won't be any more blips. But I think the prudent thing is to move ahead with these stabilizations, and note that the additional waitForText() statements seem to be sufficient as a mitigating practice, so if we do see blips in the future, that should be the first thing we look to for a remediation.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.