Many classes are very verbose now, for instance, in the Entity and Entity/Storage folder (but also Services for instance):

ActivityPubActivityAccessControlHandler.php
ActivityPubActivityInterface.php
ActivityPubActivityListBuilder.php
ActivityPubActivity.php
ActivityPubActivityRouteProvider.php
ActivityPubActivityViewsData.php
ActivityPubActorInterface.php
ActivityPubActor.php
ActivityPubTimelineItemInterface.php (new)
ActivityPubTimelineItem.php (new)
ActivityPubTypeAccessControlHandler.php
ActivityPubTypeInterface.php
ActivityPubTypeListBuilder.php
ActivityPubType.php
ActivityPubActivityStorageInterface.php
ActivityPubActivityStorage.php
ActivityPubActivityStorageSchema.php
ActivityPubActorStorageInterface.php
ActivityPubActorStorage.php
ActivityPubActorStorageSchema.php
ActivityPubRelationStorageInterface.php
ActivityPubRelationStorage.php

Why not drop the 'ActivityPub' prefix, the names will make a bit more sense and become less verbose in code. Plus, everything is namespaced anyway. That way, it all becomes this:

ActivityAccessControlHandler.php
ActivityInterface.php
ActivityListBuilder.php
Activity.php
ActivityRouteProvider.php
ActivityViewsData.php
ActorInterface.php
Actor.php
TimelineItemInterface.php (new)
TimelineItem.php (new)
TypeAccessControlHandler.php
TypeInterface.php
TypeListBuilder.php
Type.php
ActivityStorageInterface.php
ActivityStorage.php
ActivityStorageSchema.php
ActorStorageInterface.php
ActorStorage.php
ActorStorageSchema.php
TimelineItemStorageInterface.php
TimelineItemStorage.php

I think that makes sense. There are a couple of others which do not have this prefix, e.g. all controllers, ResolveService, Reader ..

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

swentel created an issue. See original summary.

swentel’s picture

Issue summary: View changes
swentel’s picture

swentel’s picture

Status: Postponed » Active

The parent is in, let's do this, because this makes just so much sense.

  • swentel committed 1502192e on 1.0.x
    Resolve #3577171 "Consider renaming classes"
    
swentel’s picture

Status: Active » Fixed

Woop!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.