Problem/Motivation

From berdir's comment in #3560117: [meta] Add Navigation to the Standard profile and recipes:

\Drupal\Tests\navigation\FunctionalJavascript\PerformanceTest will become mostly pointless with this change and could be removed either here or in a follow-up. The one specific assert should be moved to StandardPerformanceTest

Once #3575171 has been merged, the mentioned test can be integrated in the standard profile.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3576727

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc opened merge request !14966

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

Moving to NR

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Thanks, I think it's sensible to keep the asserts as before to ensure we don't lose any performance test coverage.

This is still a benefit because it avoids another full standard install and is now in scope of the default standard test not a navigation specific thing.

  • catch committed c2708c06 on main 
    task: #3576727 Integrate navigation's performance test in...

  • catch committed a6a39ade on 11.x 
    task: #3576727 Integrate navigation's performance test in...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Yes agreed the metrics in this one are useful. We now have navigation installed in Umami's across pages test, but that only checks js/css.

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14966

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.