Problem/Motivation

core/themes/admin/images/core/README.md:

## Purpose of this folder
Icons in this folder are copied from Drupal core. This folder with its content
should be removed before moving Claro to Drupal core. See
https://www.drupal.org/project/claro/issues/3045216 for details.

This folder was not removed before moving this theme to core.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3576497

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

quietone’s picture

quietone commented
Title: Decide what to do with core/themes/admin/images/core » Decide what to do with core/themes/default_admin/images/core

quietone opened merge request !15293

quietone’s picture

quietone commented
Status: Active » Needs review

Made an educated guess what to do here.

quietone’s picture

quietone commented

This isn't correct. For the status page, it isn't using the error/warning/check svg it should be it seems to be using icons from migration/media/icons instead.

What is the way to fix that?

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs review » Needs work

The current state of the MR is most likely conflicting with the CSS cleanup done by @mherchel and others over at #3582833: Consolidate, refactor, remove and untangle Claro's CSS from Default Admin theme which is close to get merged.

Then, when we get back to this one, let's define the scope of what we want to achieve first. Let me get started and when we have a common understanding, let's update the IS then.

The file core/themes/admin/images/core/README.md mentioned in the IS comes from Claro, not from Gin (or now default_admin). So, I guess Claro wanted to remove that folder before getting merged into core and then update their CSS to link to the core images instead of their own copy of them. And then for Gin, we've copied everything from Claro, so that we have an independent theme folder in default_admin. As a result, we now have 3 identical copies of the same directory structure:

  • core/misc/icons
  • core/themes/claro/images/core
  • core/themes/default_admin/images/core

Leaving Claro out, as it's not within scope for this issue, we should go through the following steps:

  • Verify that every file in core/themes/default_admin/images/core is also available in core/misc/icons and delete them all in the theme folder. Should there be any missing file in core/misc/icons, this needs to be raised as an issue and we need to find out what to do about it.
  • Update the CSS in default_admin to reference those files in core/misc/icons instead of from the theme

Not mentioned in the IS but in #5, there are also icons in core/themes/default_admin/migration/media/icons that need to be addressed separately such that they should be deduplicated and moved over to core/themes/default_admin/images/icons.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Closed (duplicate)

Closing this as a duplicate of #3603162: Consolidate and cleanup media - icons, SVGs and others, where the work is occurring.

My thought is that we can clean up core's images in general, but we can do that in a followup if needed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.