Problem/Motivation

Stable 9 is being deprecated and there are uses in test.

Steps to reproduce

Proposed resolution

Change from using stable9 to a test theme.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575876

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14920

quietone’s picture

quietone commented
Title: Replace stable9 with test theme in tests » Replace stable9 with test_theme_base theme in tests
Issue summary: View changes

This was created from work done by andypost in #3567667: Deprecate Stable9 and moved here to keep that issue for only the deprecation. I am adding credit for andypost here.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review

There are other PHP tests where the 'stable9' is found. These need to be addressed here or another issue.

$ git grep -i stable9 | grep -v Stable9 | grep Test.php
core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaPreviewTest.php:    // stable9/templates/content/media-embed-error.html.twig.
core/modules/node/tests/src/Functional/NodeRssCacheTest.php:    // Teaser must contain an "<article" tag from the stable9 theme.
core/modules/views/tests/src/Functional/Plugin/StyleSummaryTest.php:    $this->assertSession()->responseContains('stable9/css/views/views.module.css');
core/tests/Drupal/Tests/Core/Extension/ModuleRequiredByThemesUninstallValidatorTest.php:      'stable9' => [
core/tests/Drupal/Tests/Core/Extension/ModuleRequiredByThemesUninstallValidatorTest.php:      'stable9' => [
core/tests/Drupal/Tests/Core/Extension/ModuleRequiredByThemesUninstallValidatorTest.php:      'stable9' => [
andypost’s picture

andypost
he/him
Primary language Russian
commented 
core/modules/big_pipe/tests/themes/big_pipe_test_theme/big_pipe_test_theme.info.yml:3:base theme: stable9
core/modules/block/tests/modules/block_test/themes/block_test_special_chars_theme/block_test_special_chars_theme.info.yml:3:base theme: stable9
core/modules/block/tests/modules/block_test/themes/block_test_theme/block_test_theme.info.yml:3:base theme: stable9
core/modules/config_translation/tests/themes/config_translation_test_theme/config_translation_test_theme.info.yml:3:base theme: stable9
core/modules/help/tests/themes/help_topics_test_theme/help_topics_test_theme.info.yml:3:base theme: stable9
core/modules/system/tests/themes/test_core_semver/test_core_semver.info.yml:3:base theme: stable9
core/modules/system/tests/themes/test_invalid_core_semver/test_invalid_core_semver.info.yml:3:base theme: stable9
core/modules/system/tests/themes/test_invalid_region/test_invalid_region.info.yml:3:base theme: stable9
core/modules/system/tests/themes/test_theme_having_veery_long_name_which_is_too_long/test_theme_having_veery_long_name_which_is_too_long.info.yml:2:base theme: stable9
core/modules/system/tests/themes/test_theme_settings_features/test_theme_settings_features.info.yml:3:base theme: stable9
core/modules/system/tests/themes/test_theme_twig_registry_loader/test_theme_twig_registry_loader.info.yml:3:base theme: stable9
core/modules/update/tests/themes/update_test_base_theme/update_test_base_theme.info.yml:3:base theme: stable9
core/modules/user/tests/themes/user_test_theme/user_test_theme.info.yml:3:base theme: stable9
core/modules/views/tests/themes/views_test_checkboxes_theme/views_test_checkboxes_theme.info.yml:3:base theme: stable9
core/modules/views/tests/themes/views_test_theme/views_test_theme.info.yml:3:base theme: stable9
core/profiles/tests/testing_config_import/testing_config_import_theme/testing_config_import_theme.info.yml:3:base theme: stable9
core/tests/fixtures/test_stable/test_stable.info.yml:3:base theme: stable9

gonna replace most of it too

andypost’s picture

andypost
he/him
Primary language Russian
commented

The only question left is starterkit_theme has
core/themes/starterkit_theme/starterkit_theme.info.yml:3:'base theme': stable9

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3567309: If Stable9 is removed from core, what should be the base theme for starterkit_theme?
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I couldn't find anything to comment on while reading through the review. At first, I was confused by test_theme creating and then overriding its own libraries, but I get it now. It works.

grep -rni "stable9" core/modules/*/tests/ core/themes/*/tests/ core/tests only returned results for two classes: Stable9LibraryOverrideTest and Stable9TemplateOverrideTest. Obviously, those aren't in the scope of this issue.

Considering that tests are still passing, I think this issue is good to go.

catch closed merge request !14920

  • catch committed 8a78f9aa on 11.x 
    task: #3575876 Replace stable9 with test_theme_base theme in tests

By:...

  • catch committed c8851a15 on main 
    task: #3575876 Replace stable9 with test_theme_base theme in tests

By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Thank you, now only deprecation left #3567667: Deprecate Stable9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.