Problem/Motivation

While working on removing Migrate Drupal UI, there were test failures dues to trying to install an obsolete module.

Steps to reproduce

One way to find tests is

$ git grep -l ExtensionLifecycle::LIFECYCLE_IDENTIFIE | grep Test.php
core/modules/config/tests/src/Functional/ConfigImportAllTest.php
core/modules/help/tests/src/Functional/HelpTopicsSyntaxTest.php
core/modules/jsonapi/tests/src/Kernel/TestCoverageTest.php
core/modules/rest/tests/src/Kernel/EntityResource/EntityResourceRestTestCoverageTest.php
core/modules/system/tests/src/Functional/Theme/EntityFilteringThemeTest.php
core/tests/Drupal/KernelTests/Config/DefaultConfigTest.php
core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
core/tests/Drupal/KernelTests/Core/Extension/ModuleConfigureRouteTest.php
core/tests/Drupal/KernelTests/Core/Theme/Stable9TemplateOverrideTest.php
core/tests/Drupal/Tests/Core/Extension/InfoParserUnitTest.php

Proposed resolution

Modify tests that are not testing install of an obsolete extension to not try to install an obsolete extension.

Add a check for obsolete in the relevant test in these files.

  • core/modules/config/tests/src/Functional/ConfigImportAllTest.php
  • core/modules/jsonapi/tests/src/Kernel/TestCoverageTest.php
  • core/modules/rest/tests/src/Kernel/EntityResource/EntityResourceRestTestCoverageTest.php
  • core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php
  • core/tests/Drupal/KernelTests/Core/Extension/ModuleConfigureRouteTest.php
  • core/tests/Drupal/KernelTests/Core/Theme/Stable9TemplateOverrideTest.php
  • core/tests/Drupal/KernelTests/Core/Theme/StableLibraryOverrideTestBase.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575871

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14917

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review
nicxvan’s picture

nicxvan commented

Should we do something like this https://www.drupal.org/project/drupal/issues/3271010

quietone’s picture

quietone commented

I would think so. However, later. I don't want to delay this change because it is blocking removing of Migrate Drupal UI and Migrate Drupal.

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Critical

Bumping to critical because it blocks making modules obsolete at all.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Since this appears to be the same change that was used in the remove migrate ticket and know it works going to mark.

Really surprised this never came up before? But guess we haven’t been marking modules obsolete just deprecated.

  • catch committed d50396bb on 11.x 
    fix: #3575871 Most tests should not try to install obsolete modules

By...

  • catch committed 87f07876 on main 
    fix: #3575871 Most tests should not try to install obsolete modules

By...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Yeah we haven't marked many modules obsolete yet.

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14917

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.