Problem/Motivation

The removal of extension Migrate Drupal UI was approved in #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL.

Steps to reproduce

Remaining tasks

Postponed on #3575871: Most tests should not try to install obsolete modules

  • The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-migrate-drupal-ui. (For example, the CR for removing HAL)
  • Tag this issue 'Needs release note.'
  • Remove the extension ;-).
  • Remove lines in \Drupal\KernelTests\Core\Asset\ResolvedLibraryDefinitionsFilesMatchTest::testCoreLibraryCompletenessDeprecated that were added in #3463321: Deprecate Migrate Drupal UI.
  • Remove migrate_drupal_ui/base: from stable9.info.yml and the related CSS file.
  • Remove references from core/phpstan-baseline.neon.
  • Remove any spelling words specific to the extension from the dictionary
  • Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.
  • Check for references in @todo.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3574714

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14844

quietone’s picture

quietone commented
Issue summary: View changes

There is a reference in a comment in Migrate Drupal which is relevant to the use of source_module, so worth keeping in Migrate Drupal.

$ git grep -ri "migrate drupal u"
core/modules/migrate_drupal/src/MigrationPluginManager.php: * order to support the Migrate Drupal UI, which needs to know which modules
quietone’s picture

quietone commented
Issue tags: +12.0.0 release notes
quietone’s picture

quietone commented
Status: Active » Needs review

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

I pushed one change. I would assume when installAllModules() is called it should also skip obsolete modules. But there are still tests failing and I don't want to hijack this from @quietone

quietone’s picture

quietone commented

The changes to the tests in the last few commits would be better in a separate issue. This removal is merely exposing the problem with those tests.

smustgrave’s picture

smustgrave commented

That's up to you! I'm willing to mark this one though.

Think just need to update GenericTestExistsTest

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Postponed

Postponed on #3575871: Most tests should not try to install obsolete modules

quietone’s picture

quietone commented
Status: Postponed » Needs review

#3575871: Most tests should not try to install obsolete modules has been committed. I restarted the tests.

catch’s picture

catch
he/him
Primary language English
commented

One comment on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Going to cause a lot of merge conflicts with the baseline removals but worth it :)

Removal LGTM

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14844

  • catch committed f215e25c on main 
    task: #3574714 Remove Migrate Drupal UI from core

By: quietone
By:...
quietone’s picture

quietone commented

Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.

We all missed this step in the Issue summary. I have resolved that by adding it to the Migrate Drupal removal. #3572280: Remove Migrate Drupal

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.