Problem/Motivation

Part of deprecating Search module.

Steps to reproduce

Proposed resolution

These tests still pass when Search is not installed.

  • core/modules/field_ui/tests/src/Functional/ManageDisplayTest.php
  • core/modules/node/tests/src/Functional/NodeAccessBaseTableTest.php
  • core/modules/views/tests/src/Functional/DefaultViewsTest.php
  • core/modules/views/tests/src/Kernel/Entity/ViewEntityDependenciesTest.php
  • core/tests/Drupal/FunctionalJavascriptTests/Ajax/AjaxFormCacheTest.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575587

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14905

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Followed up to @dcam comment.

quietone’s picture

quietone commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented

Should BlockHiddenRegionTest be addressed too?

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Think BlockHiddenRegionTest could be included. Needs a little refactoring but it's not actually doing anything search related. Just label checking.

quietone’s picture

quietone commented
Status: Needs work » Needs review

It looks to me that that test will need a replacement block to test with. For me, that moved it out this set of very easy ones.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Hey guys, I'm sorry I didn't come back to this sooner. I usually try to follow up on my reviews right away.

My feedback was addressed. And the new changes to BlockHiddenRegionTest look OK to me. In my opinion the changes are simple enough. They're similar to the change we made in AjaxFormCacheTest. So I would include them.

The one thing I don't get is that the BlockHiddenRegionTest dockblock's comment says:

Tests that hidden regions do not inherit blocks when a theme is installed.

But I can't tell that there's any check that a block isn't inherited. Maybe it does and I just don't understand it due to a lack of comments in the test function.

Anyway, the test_form_in_block appears to be a drop-in replacement for the search block here too, with only minor text changes required to make the test continue to work.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14905

  • catch committed 7bfc5fd5 on main 
    task: #3575587 Remove Search from tests, easy ones

By: quietone
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Status: Closed (fixed) » Active

Re-opening as part of deprecating Search. These changes should be on 11.x as well.

quietone opened merge request !16996

quietone’s picture

quietone commented
Version: main » 11.x-dev
Issue tags: +Needs release manager review
quietone’s picture

quietone commented
Status: Active » Needs review
quietone’s picture

quietone commented

I cherry-picked the commit from main. There was one conflict, in ViewEntityDependenciesTest.php

smustgrave’s picture

smustgrave commented

Does this need release manager for main too? Should that be reverted?

quietone’s picture

quietone commented

The commit on main is correct, there is nothing to change on main. This just should have been committed to 11.x but was missed. It was discovered when backporting the deprecation of Search to 11.x, #3565781-30: Deprecate the Search module

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed
Issue tags: -Needs release manager review

Backport looks straightforward, going ahead here. Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 4ccdcd3e on 11.x 
    task: #3575587 Remove Search from tests, easy ones

By: quietone
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.