Problem/Motivation

Drupal is in the middle of a multi-year effort to reduce or remove jQuery as a dependency. SAML SP uses it and I don’t think we need to.

Proposed resolution

Rewrite js/idp_form.js to use “vanilla” JavaScript.

Issue fork saml_sp-3575001

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3575001-remove-jquery Comparechanges, plain diff MR !76
    • 1 hidden branch
  • 4.x Comparecompare
About issue forks

Comments

jproctor created an issue. See original summary.

adrury made their first commit to this issue’s fork.

jproctor changed the visibility of the branch 4.x to hidden.

adrury opened merge request !76

adrury’s picture

adrury
she/her/hers
Primary language English
commented
Status: Active » Needs review

This branch:

  • - Removes as much jQuery as possible
  • - Tells eslint to ignore the jQuery that can't be removed yet
  • - Ensures that certificates are only copied from the XML onto the form uniquely

The jQuery that can't be removed yet is the AJAX-related jQuery. It appears that core is still emitting ajaxComplete as a jQuery event, which is not catchable in plain JavaScript.

  • jproctor committed 6b656571 on 4.x authored by adrury 
    feat: #3575001 Remove jQuery from idp_form.js

By: jproctor
By: adrury
jproctor’s picture

jproctor
they/them
Primary language English
commented
Status: Needs review » Fixed

Thank you!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.