Problem/Motivation

Made this one a larger scope as I intend to work on it the lib deprecations have not been straight forward.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3574859

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Title: Remove deprecated code from lib/Validation, lib/theme, lib/Test, lib/StackMiddleware » Remove deprecated code from lib/Validation, lib/Session, lib/Test, lib/StackMiddleware

Replaced theme with session as @nicxvan and @berdir may be working on the theme stuff.

smustgrave opened merge request !14850

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

Believe this one is ready

dcam’s picture

dcam commented
Status: Needs review » Needs work

I left a few comments on the MR.

Also, there's a lingering reference to TestDiscovery::getTestClasses() in MissingGroupException. See https://git.drupalcode.org/project/drupal/-/blob/main/core/lib/Drupal/Co....

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Thanks for the great review!

dcam’s picture

dcam commented
Status: Needs review » Needs work

Sorry, one more change needed.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Thanks!

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Feedback was addressed. LGTM.

smustgrave’s picture

smustgrave commented

Rebased

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

One question on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Added a typeError, change thought was small enough to go back to RTBC. If I'm wrong I apologize

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Reviewed & tested by the community » Needs work
Related issues: +#3550268: Remove deprecated paths from the testing framework

Mmmm I think we're removing too much from the testing framework here. Please cross-check with #3550268: Remove deprecated paths from the testing framework. For instance, core/tests/Drupal/KernelTests/Core/Test/PhpUnitApiGetTestClassesTest.php should not be completely removed IMHO.

smustgrave’s picture

smustgrave commented

I'll pull out lib/Test and replace with something else to not cross streams.

smustgrave closed merge request !14850

smustgrave opened merge request !14924

smustgrave closed merge request !14924

smustgrave opened merge request !14925

smustgrave’s picture

smustgrave commented
Title: Remove deprecated code from lib/Validation, lib/Session, lib/Test, lib/StackMiddleware » Remove deprecated code from lib/menu, lib/routing, lib/session, lib/StackMiddleWare, and lib/Validation
smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I found several items to look at and left comments for them on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Thanks!

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I reviewed the additional changes. My feedback on them has been addressed. They look good to me.

smustgrave’s picture

smustgrave commented

Rebased with the latest removals.

  • catch committed 2a9fde3d on main 
    refactor: #3574859 Remove deprecated code from lib/menu, lib/routing,...

catch closed merge request !14925

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.