Problem/Motivation

Cleanup of deprecated code for the testing framework.

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3550268

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Parent issue: #3525077: Remove deprecated paths from the Database API & friends »

mondrake opened merge request !13408

mondrake’s picture

mondrake
Location 🇮🇹
commented
Component: database system » phpunit

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
Related issues: +#3552827: Replace all expectDeprecation() calls with expectUserDeprecationMessage()
mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: [D12] Remove deprecated paths from the testing framework » Remove deprecated paths from the testing framework
Issue summary: View changes
Status: Postponed » Needs review

Blocker is in.

dcam’s picture

dcam commented
Status: Needs review » Needs work

I found a couple of lingering doc references to deleted functions, but I also noticed what looks like a loss of test coverage. Please let me know if I'm wrong. Setting to Needs Work to take care of these items.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review

Thanks for the review! Replied inline.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

My feedback was addressed. LGTM.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: Unassigned » mondrake
Status: Reviewed & tested by the community » Needs work

Maybe I found a way to test that without too much effort. Stay tuned.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: mondrake » Unassigned
Status: Needs work » Needs review

Reintroduced the test + an additional one. In fact there was a bug - TestCase::groups() always return at least one group, so the empty check was moot. Here we are checking explicitly that the group attribute is defined on the test using PHPUnit API.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The new tests look great. I couldn't find anything to comment on about them. Thank you for taking another look at replacing that deleted test.

mondrake’s picture

mondrake
Location 🇮🇹
commented

rebased

quietone’s picture

quietone commented
Parent issue: » #3553503: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules from Drupal 12

Adding all deprecated removals to the meta

mondrake’s picture

mondrake
Location 🇮🇹
commented

rebased a bit robustly - DebugClassLoader deprecations started to get in the way and I added native return types as recommended.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs another rebase. There are more additions in here than I expected, e.g. in PhpUnitTestDiscovery, does this mean we didn't complete some deprecations? I think it's probably fine to do it all in one go in this issue though since those classes are very internal.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Reviewed & tested by the community

Honestly I never looked at deprecation options when touching the classes that are only used by run-tests.sh or by PHPUnit extensions.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Still getting a conflict on ore/tests/Drupal/Tests/UnitTestCase.php

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Reviewed & tested by the community

Merged with main

catch closed merge request !13408

  • catch committed 53fc6086 on main 
    task: #3550268 Remove deprecated paths from the testing framework

By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.