Problem/Motivation

There are 13 deprecation in the comments module that needs to be removed. This one may be a bit more tricky so feel free to ask questions.

This involves updating the type + documentation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3574661

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

andypost made their first commit to this issue’s fork.

andypost opened merge request !14842

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Remaining deprecations are for 13.x

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Issue tags: -fldc26

Thanks! Andypost I forgot you were comment maintainer that's why I tagged for the camp. Mind fixing the phpstan issue?

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Actually see more instances in comment.libraries, CommentUriDeprecationTest, CommentBreadcrumbBuilder, CommentLinkBuilder

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
Related issues: +#3459277: Enforce second parameter in BreadcrumbBuilderInterface::applies

Removed COMMENT_NEW_LIMIT as it was forgotten when history module was removed from core, ref #2006632-57: Make HISTORY_READ_LIMIT configurable

PS #3570668: Remove History module from core

I cleaned and then reverted CommentBreadcrumbBuilder because it should be done in #3459277: Enforce second parameter in BreadcrumbBuilderInterface::applies

andypost’s picture

andypost
he/him
Primary language Russian
commented

@smustgrave sorry about misunderstanding about tagging for camp, just got a time to clean my stuff)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Deprecation Removal
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Applying #7 and searching again all deprecations are removed.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14842

  • catch committed 1c2aa7b0 on main 
    task: #3574661 Remove deprecated code from comments module

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.