Problem/Motivation

Allow disabling (status) advertisement placements. They should then only appear in the admin list, but nowhere else.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ad-3574333

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !42

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@lrwebks: Please finish. I think you already did this somewhere else.
Please note my draft and that enable / disable is controlled by link templates in core and status is already inherited from ConfigEntityBase

Maybe you still need to add the routing.yml entries and possibly other things?
Do you remember where we did that already?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: lrwebks » grevil

@grevil can you please finish this, we'll need this soon and shouldn't be too hard IMHO.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review

Alright, that should be it. I orientated myself on Block regarding the disable / enable logic (using a Controller instead of dedicated Forms).

grevil’s picture

grevil commented
Title: Allow disabling (status) advertisement placements » Allow disabling, duplicating advertisement placements
Status: Needs review » Needs work

Whoops, forgot the duplicate request.

grevil’s picture

grevil commented
Status: Needs work » Needs review

Ok, now all is done.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Fixed

Works like a charm!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • anybody committed 39b6905b on 11.x 
    feat: #3574333 Allow disabling (status) advertisement placements  By:...
grevil’s picture

grevil commented

Nice! I created a new release: https://www.drupal.org/project/ad/releases/11.0.0-alpha9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.