Problem/Motivation

Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...) and add tests for all functionalities

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ad-3574316

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

lrwebks opened merge request !46

lrwebks made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Active » Needs work

@grevil: @lrwebks doesn't know why the test fails now (also locally) - any ideas? (NOT IMPORTANT OR URGENT!), but maybe you have a quick idea.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
  • You accidentally reverted an if case. Happens to the best, but the change wasn't needed.
  • We also can not simply change ids just like this, even though they are flagged by cspell, please create a cspell ignore and ignore the ids.
  • Also lambda functions generally change the this context, even when its not needed, you can keep it, as we are not using this, but I generally dislike it.
grevil’s picture

grevil commented
Status: Needs work » Reviewed & tested by the community

Ok, that should be it. Othwerise LGTM! Let's wait for the tests to turn green.

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

All green, merging!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • grevil committed 1bbc13aa on 11.x authored by lrwebks 
    feat: #3574316 Fix code style (phpcs. phpstan, styleint, cspell, eslint...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.