Lines 114-121 of HackedProjectWebDevDownloader.php throw an exception with an array as second parameter but the second parameter of the \Exception object is supposed to be the exception code, I think there's a t() call missing.

    // Throw an exception if it didn't work.
    if ($return_value != 0) {
      throw new \Exception('Could not clone project %project into path %path at branch %branch.', [
        '%project' => $this->project->title(),
        '%path' => $path,
        '%branch' => $branch,
      ]);
    }

Issue fork hacked-3574227

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pcambra created an issue. See original summary.

pcambra’s picture

Status: Active » Needs review
ivnish’s picture

Drupal Coding Standards:

DO NOT translate the message.

https://project.pages.drupalcode.org/coding_standards/php/exceptions/

pcambra’s picture

You still can't send random arrays as a second param of an \Exception no matter what the Drupal coding standards say :)

I've replaced it by a sprintf

  • ivnish committed 8f61c536 on 8.x-2.x authored by pcambra
    fix: #3574227 Exception malformed on HackedProjectWebDevDownloader
    
    By:...
ivnish’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.